Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ads are not shown as Confirmations are not initialized when joining rewards #5747

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 5, 2020

Resolves brave/brave-browser#10096

Submitter Checklist:

Test Plan:

See brave/brave-browser#10096

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey requested review from emerick and NejcZdovc June 5, 2020 00:40
@tmancey tmancey self-assigned this Jun 5, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey requested a review from yachtcaptain23 June 5, 2020 01:00
@tmancey
Copy link
Collaborator Author

tmancey commented Jun 5, 2020

CI failed for unrelated rewards browser test

@tmancey tmancey merged commit 96d73cb into master Jun 5, 2020
@tmancey tmancey deleted the issues/10096 branch June 5, 2020 07:23
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jun 5, 2020
@LaurenWags
Copy link
Member

Verified passed using

Brave | 1.12.45 Chromium: 83.0.4103.116 (Official Build) nightly (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads are not shown as confirmations are not initialized when joining rewards
4 participants