Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebAudio farbling updates (uplift to 1.10.x) #5912

Closed
wants to merge 2 commits into from
Closed

WebAudio farbling updates (uplift to 1.10.x) #5912

wants to merge 2 commits into from

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jun 19, 2020 •
edited
Loading

Uplift of #5794
Resolves brave/brave-browser#9187

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@pilgrim-brave @bsclifton
Implement farbling levels for webaudio
b0a0689 
code and tests

use inline function instead of define
@bsclifton bsclifton requested a review from a team June 19, 2020 06:37
@bsclifton bsclifton requested a review from bridiver as a code owner June 19, 2020 06:37
@bsclifton bsclifton self-assigned this Jun 19, 2020
@pilgrim-brave pilgrim-brave mentioned this pull request Jun 19, 2020
Closed
4 tasks
@bsclifton bsclifton changed the title Implement farbling levels for webaudio (uplift to 1.10.x) WebAudio farbling updates (uplift to 1.10.x) Jun 21, 2020
@bsclifton
Copy link
Member Author

Closing after discussing with @pes10k - functionality seems to work fine, but there's a problem with the test. Reproducible via:
npm run test -- brave_browser_tests --filter=BraveWebAudioFarblingBrowserTest.*

@bsclifton bsclifton closed this Jun 21, 2020
@bsclifton bsclifton deleted the mpilgrim_webaudio_v2-1.10.x branch June 21, 2020 08:23
@bsclifton bsclifton removed this from the 1.10.x - Desktop Placeholder milestone Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @pilgrim-brave @pes10k