-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not start process if rewards is off #5924
Conversation
cec7d69
to
76c21f7
Compare
76c21f7
to
4298819
Compare
4298819
to
6e50aee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vendor/bat-native-ledger/src/bat/ledger/internal/database/database_contribution_info.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I'd like to understand better why we have the process-supporting infrastructure we have (like the mojo ledger bridge classes, for instance) at some point.
I was a little confused at first about the "startRewards"/"stopRewards" methods in the UI components, since they don't seem to start and stop the service.
@zenparsing happy to explain it |
6e50aee
to
8c275a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Resolves brave/brave-browser#9526
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.