Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes when rewards is reset ads service should shut down - 1.12.x #6287

Closed
wants to merge 1 commit into from
Closed

Fixes when rewards is reset ads service should shut down - 1.12.x #6287

wants to merge 1 commit into from

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 31, 2020

Uplift of #6284
Resolves brave/brave-browser#11035

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team July 31, 2020 11:46
@tmancey tmancey requested a review from NejcZdovc as a code owner July 31, 2020 11:46
@tmancey tmancey self-assigned this Jul 31, 2020
@NejcZdovc NejcZdovc removed their request for review July 31, 2020 11:50
@tmancey tmancey force-pushed the issues/11035-1.12.x branch from 82fe50b to 835b89f Compare July 31, 2020 19:16
@tmancey
Copy link
Collaborator Author

tmancey commented Aug 3, 2020

Closing issue as merged fix with #6300

@tmancey tmancey closed this Aug 3, 2020
@NejcZdovc NejcZdovc deleted the issues/11035-1.12.x branch August 3, 2020 14:00
@NejcZdovc NejcZdovc removed the request for review from a team August 3, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tmancey