Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes OK translation #661

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Fixes OK translation #661

merged 1 commit into from
Oct 17, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 17, 2018

Resolves brave/brave-browser#1633

UI implementation: brave/brave-ui#217

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • click on BAT logo
  • make sure that translation for OK is OK

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Oct 17, 2018
@NejcZdovc NejcZdovc requested review from bbondy and ryanml October 17, 2018 08:23
@NejcZdovc NejcZdovc merged commit afb4e7f into master Oct 17, 2018
@NejcZdovc NejcZdovc deleted the make-ok branch October 17, 2018 12:05
NejcZdovc added a commit that referenced this pull request Oct 17, 2018
NejcZdovc added a commit that referenced this pull request Oct 17, 2018
@NejcZdovc
Copy link
Contributor Author

master afb4e7f
0.57.x 27bd017
0.56.x 0aa52e9
0.55.x 985d8f0

NejcZdovc added a commit that referenced this pull request Oct 17, 2018
@bsclifton bsclifton changed the title Fixes OK transaltion Fixes OK translation Oct 17, 2018
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification button on Brave Rewards Panel says MISSING:OK
2 participants