Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restores branding path config arg for Android. #6619

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

mkarolin
Copy link
Collaborator

This arg is needed on Android so that the correct .grd is used (e.g
brave_strings.grd instead of chromium_strings.grd, see
chrome-app-BUILD.gn.patch).

Fixes brave/brave-browser#11656

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

This arg is needed on Android so that the correct .grd is used (e.g
brave_strings.grd instead of chromium_strings.grd, see
chrome-app-BUILD.gn.patch).

Fixes brave/brave-browser#11656
@mkarolin mkarolin added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 10, 2020
@mkarolin mkarolin added this to the 1.16.x - Nightly milestone Sep 10, 2020
@mkarolin mkarolin self-assigned this Sep 10, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin merged commit d89b7c4 into master Sep 10, 2020
@mkarolin mkarolin deleted the maxk-fix-android-branding branch September 10, 2020 20:58
mkarolin added a commit that referenced this pull request Sep 10, 2020
Restores branding path config arg for Android.
mkarolin added a commit that referenced this pull request Sep 10, 2020
Restores branding path config arg for Android.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] location message says "Chromium" instead of "Brave"
2 participants