Fix referrer protections for frame redirects. #6674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarier
reviewed
Sep 22, 2020
There was a problem hiding this comment.
I assume you've tested these changes using https://referrer.fmarier.org/redirects.html?
components/content_settings/renderer/brave_content_settings_agent_impl_browsertest.cc
Outdated
Show resolved
Hide resolved
components/content_settings/renderer/brave_content_settings_agent_impl_browsertest.cc
Outdated
Show resolved
Hide resolved
components/content_settings/renderer/brave_content_settings_agent_impl_browsertest.cc
Show resolved
Hide resolved
components/content_settings/renderer/brave_content_settings_agent_impl_browsertest.cc
Show resolved
Hide resolved
iefremov
force-pushed
the
ie_referrer_redirect2
branch
from
71ec0ed to
b149a22
Compare
sure thing |
iefremov
commented
Sep 22, 2020
| method_ = redirect_info.new_method; | ||
| referrer_ = redirect_info.new_referrer; | ||
| referrer_policy_ = redirect_info.new_referrer_policy; | ||
| + BRAVE_REDIRECT_CLEARREFERRER |
There was a problem hiding this comment.
@bridiver There is no way to update referrer in URLRequest (which actually sends this header to the network) via existing URLLoader/URLLoaderClient APIs , so I had to patch. An alternative was to use "extra" headers in BraveProxyingURLLoaderFactory, but earlier we decided to ban this approach due to potential negative performance implications.
fmarier
approved these changes
Sep 22, 2020
iefremov
force-pushed
the
ie_referrer_redirect2
branch
from
91a5ef2 to
25ebe29
Compare
iefremov
force-pushed
the
ie_referrer_redirect2
branch
from
48832ce to
f1a6da6
Compare
mkarolin
reviewed
Oct 15, 2020
Comment on lines
23
to
28
| original_method, | ||
| redirect_info, | ||
| removed_headers, | ||
| modified_headers, | ||
| request_headers, | ||
| should_clear_upload); |
There was a problem hiding this comment.
Formatting looks a bit odd here.
bridiver
approved these changes
Oct 15, 2020
iefremov
force-pushed
the
ie_referrer_redirect2
branch
from
1d2cee1 to
49cd189
Compare
iefremov
force-pushed
the
ie_referrer_redirect2
branch
from
49cd189 to
48c0a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/brave/internal/issues/679
Fix brave/brave-browser#7933
Resolves
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.