-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes transaction amount #6757
Fixes transaction amount #6757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
denomination.SetDoubleKey("amount", transaction.amount); | ||
denomination.SetStringKey( | ||
"amount", | ||
base::StringPrintf("%f", transaction.amount)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking if any old clients are sending this in the wrong format? Maybe need to make sure iOS gets this one if they recently updated to 1.15.x? cc @kylehickinson just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snippet from the issue report:
Important: This is regression in 1.15.x. Not reproducible on 1.14.x
LGTM Verification passed on
No more errors in the logs. For
0.95 Bat to the creator:
Verified the transactions are listed on uphold Also verified by tipping 10 BAT to a youtube creator |
Resolves brave/brave-browser#11818
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
defined in the issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.