-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable Safe Browsing download protection #6763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Oct 5, 2020
...chrome-browser-safe_browsing-download_protection-check_client_download_request_base.cc.patch
Show resolved
Hide resolved
iefremov
reviewed
Oct 7, 2020
chromium_src/chrome/browser/component_updater/file_type_policies_component_installer.cc
Outdated
Show resolved
Hide resolved
iefremov
approved these changes
Oct 7, 2020
fmarier
force-pushed
the
enable-download-protection-6267
branch
2 times, most recently
from
October 8, 2020 02:40
383b2cd
to
214c913
Compare
fmarier
commented
Oct 8, 2020
.../chrome/browser/safe_browsing/download_protection/download_protection_service_browsertest.cc
Outdated
Show resolved
Hide resolved
fmarier
force-pushed
the
enable-download-protection-6267
branch
from
October 14, 2020 01:53
214c913
to
a8edead
Compare
fmarier
force-pushed
the
enable-download-protection-6267
branch
from
October 16, 2020 03:10
a8edead
to
8306a54
Compare
bridiver
reviewed
Oct 19, 2020
bridiver
reviewed
Oct 19, 2020
chromium_src/chrome/browser/component_updater/file_type_policies_component_installer.cc
Outdated
Show resolved
Hide resolved
This is needed for the download protection component of Safe Browsing.
fmarier
force-pushed
the
enable-download-protection-6267
branch
from
October 19, 2020 21:08
8306a54
to
fd247c8
Compare
bridiver
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#6267
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
Try downloading the following files:
In addition, all of the files under Desktop Download Warnings on https://testsafebrowsing.appspot.com/ should be blocked.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.