Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Safe Browsing download protection #6763

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Oct 2, 2020

Resolves brave/brave-browser#6267

Submitter Checklist:

Test Plan:

Try downloading the following files:

In addition, all of the files under Desktop Download Warnings on https://testsafebrowsing.appspot.com/ should be blocked.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier added this to the 1.17.x - Nightly milestone Oct 2, 2020
@fmarier fmarier requested review from jumde and mkarolin October 2, 2020 23:57
@fmarier fmarier self-assigned this Oct 2, 2020
@fmarier fmarier force-pushed the enable-download-protection-6267 branch 2 times, most recently from 383b2cd to 214c913 Compare October 8, 2020 02:40
@fmarier fmarier force-pushed the enable-download-protection-6267 branch from 214c913 to a8edead Compare October 14, 2020 01:53
@fmarier fmarier requested a review from a team as a code owner October 14, 2020 01:53
@fmarier fmarier force-pushed the enable-download-protection-6267 branch from a8edead to 8306a54 Compare October 16, 2020 03:10
@fmarier fmarier requested a review from bridiver October 16, 2020 03:14
@fmarier fmarier force-pushed the enable-download-protection-6267 branch from 8306a54 to fd247c8 Compare October 19, 2020 21:08
@fmarier fmarier merged commit 1dcd6ed into master Oct 19, 2020
@fmarier fmarier deleted the enable-download-protection-6267 branch October 19, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable download protection remote lookups
3 participants