Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates uphold modals #6926

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Updates uphold modals #6926

merged 1 commit into from
Oct 22, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 22, 2020

Resolves brave/brave-browser#11431

Submitter Checklist:

Test Plan:

  • enable rewards
  • click on verify wallet
  • make sure that you see a note in there
  • claim grant
  • click on verify wallet
  • make sure that you see the same note as before in purple modal

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Oct 22, 2020
@NejcZdovc NejcZdovc self-assigned this Oct 22, 2020
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Oct 22, 2020
@NejcZdovc NejcZdovc marked this pull request as ready for review October 22, 2020 15:39
@NejcZdovc NejcZdovc requested a review from a team as a code owner October 22, 2020 15:39
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Uphold linking modals should be combined and have privacy warning
3 participants