Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement navigator.deviceMemory farbling #6964

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Implement navigator.deviceMemory farbling #6964

merged 1 commit into from
Nov 11, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Oct 27, 2020 •
edited by rebron
Loading

Resolves brave/brave-browser#12348

Submitter Checklist:

Test Plan:

See: brave/brave-browser#12348 (comment)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner October 27, 2020 18:40
@pilgrim-brave pilgrim-brave self-assigned this Oct 27, 2020
@mkarolin mkarolin requested a review from fmarier October 27, 2020 19:11
@mkarolin mkarolin mentioned this pull request Oct 27, 2020
Merged
33 tasks
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_farble_devicememory branch from 7fc340a to 9bd2246 Compare October 27, 2020 19:58
fmarier
fmarier approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look closely through the whole patch, but the approach LGTM.

mkarolin
mkarolin reviewed Oct 28, 2020
View reviewed changes
test/BUILD.gn Outdated Show resolved Hide resolved
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_farble_devicememory branch from 9bd2246 to b54330d Compare October 29, 2020 01:41
mkarolin
mkarolin approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak kjozwiak mentioned this pull request Oct 29, 2020
Closed
@mkarolin mkarolin mentioned this pull request Oct 30, 2020
Merged
32 tasks
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_farble_devicememory branch 2 times, most recently from bceb86a to de8d8c9 Compare November 9, 2020 16:36
@pilgrim-brave
Implement navigator.deviceMemory farbling
83a232f 
tests

BUILD.gn changes

feedback

BUILD.gn hacks
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_farble_devicememory branch from de8d8c9 to 83a232f Compare November 10, 2020 20:03
@pilgrim-brave pilgrim-brave merged commit a51299a into master Nov 11, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_farble_devicememory branch November 11, 2020 01:25
@pilgrim-brave pilgrim-brave added this to the 1.18.x - Beta milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@fmarier fmarier fmarier approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging this pull request may close these issues.

Farble navigator.deviceMemory instead of blocking it
3 participants
@pilgrim-brave @fmarier @mkarolin