Add IPFSEnabled policy to control IPFS feature #6966

yrliou · 2020-10-27T18:59:51Z

Submitter Checklist:

Test Plan:

On Linux or Windows:

Open brave browser and enable IPFS feature flag via brave://flags.
Go to brave://settings and search IPFS, should see Method to resolve IPFS locations and IPFS public gateway fallback settings available, change Method to resolve IPFS locations to Ask if not.
Visit https://dweb.link/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR, ipfs infobar should be shown to ask for enabling IPFS local node support.
Accept the infobar.
Visit brave://ipfs, page should be shown and daemon should be launched.
Quit the browser
In bash, go to profile folder, for example, ~/.config/BraveSoftware/Brave-Browser-Development on local linux build, /C/Users/yrliou/AppData/Local/BraveSoftware/Brave-Browser-Development/User Data on local windows build.
Run find . -name *go-ipfs* should have results, for example, ./oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.2/go-ipfs_v0.6.0_linux-amd64 on linux, ./lnbclahgobmjphilkalbhebakmblnbij/1.0.2/go-ipfs_v0.6.0_windows-amd64 on windows.
[Linux]
(sudo is needed in this step) Go to /etc/brave/policies/managed (create folders if not exists already), create test_policy.json with content:

{
  "IPFSEnabled": false
}

[Windows]
Open regedit, for 64 bit, create the following keys:
BraveSoftware\Brave under the existing key HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Policies
(for 32 bit, you can edit HKEY_LOCAL_MACHINE\SOFTWARE\Policies)
Create a DWORD value at this path called IPFSEnabled and set the value as 0
Open brave again
Go to brave://policy, should see:

Go to brave://settings and search IPFS, Method to resolve IPFS locations and IPFS public gateway fallback settings should not be available
Go to brave://ipfs, should show an error page saying This site can’t be reached.
Visit https://dweb.link/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR, no infobar is shown.
Do step 7 again, this time it should be an empty result. (no daemon binary can be found now)

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on.
All relevant documentation has been updated.

yrliou · 2020-10-29T21:48:30Z

browser/brave_content_browser_client.cc

-        &ipfs::ContentBrowserClientHelper::HandleIPFSURLRewrite,
-        &ipfs::ContentBrowserClientHelper::HandleIPFSURLReverseRewrite);
-  }
+  handler->AddHandlerPair(


condition checks are done in those static functions in content_browser_client_helper.cc now, remove the condition checks in this file.

yrliou · 2020-10-29T22:07:25Z

browser/ipfs/ipfs_service_factory.cc

+  // Because we currently do not provide a settings switch for IPFSEnabled
+  // preference to be overwritten by users, the policy is configured that only
+  // a mandatory value can be set by admins.
+  return local_state->IsManagedPreference(kIPFSEnabled) &&


I didn't expose a new settings switch cuz there will be too much settings and could cause confusion.
Users are still able to set the resolve method (per-profile setting) as disabled in the settings which will be respected immediately without restarting the browser as before.
This new kIPFSEnabled pref is only for admins to add a mandatory policy to disable the whole IPFS feature for the machine and will remove the binary if already downloaded.

yrliou · 2020-10-29T22:10:35Z

components/ipfs/ipfs_switches.h

-namespace ipfs {
-
-// Allows disabling the Ipfs client updater extension.
-constexpr char kDisableIpfsClientUpdaterExtension[] =


This command-line switch is removed because we already have a feature flag to control IPFS.

yrliou · 2020-10-29T23:04:10Z

chromium_src/chrome/browser/policy/configuration_policy_handler_list_factory.cc

-#if BUILDFLAG(ENABLE_TOR)
+// Wrap whole array definition in build flags to avoid unused variable build
+// error. It can happen if the platform doesn't support any of these features.
+#if BUILDFLAG(ENABLE_TOR) || BUILDFLAG(IPFS_ENABLED)


FYI The only chromium_src change is this file.

simonhong

LGTM 👍

yrliou · 2020-10-30T05:41:43Z

CI only had known rewards failures.
mac: RewardsContributionBrowserTest.PanelMonthlyTipAmount
windows: RewardsContributionBrowserTest.RecurringTipForUnverifiedPublisher

bbondy

lgtm!

mkarolin

chromium_src changes LGTM

simonhong · 2020-10-30T16:17:31Z

@yrliou How about filing an issue for group policy directory path?
I think /etc/chromium/policies/managed should be /etc/brave/policies/managed.

yrliou · 2020-10-30T17:09:43Z

The latest windows CI build is aborted due to node is removed.
My last rebase is just resolving a trivial merge conflict, merging as windows is already passed before it.

yrliou added this to the 1.18.x - Nightly milestone Oct 27, 2020

yrliou self-assigned this Oct 27, 2020

yrliou force-pushed the ipfs_admin_policy branch 7 times, most recently from 725f654 to 4247f1c Compare October 29, 2020 21:45

yrliou marked this pull request as ready for review October 29, 2020 21:45

yrliou requested a review from a team as a code owner October 29, 2020 21:45

yrliou requested review from bbondy and simonhong October 29, 2020 21:45

yrliou commented Oct 29, 2020

View reviewed changes

yrliou force-pushed the ipfs_admin_policy branch from 4247f1c to 7e23ed0 Compare October 29, 2020 22:00

yrliou commented Oct 29, 2020

View reviewed changes

yrliou force-pushed the ipfs_admin_policy branch from 7e23ed0 to 9f83606 Compare October 29, 2020 22:12

yrliou commented Oct 29, 2020

View reviewed changes

simonhong approved these changes Oct 30, 2020

View reviewed changes

bbondy approved these changes Oct 30, 2020

View reviewed changes

yrliou added 2 commits October 30, 2020 08:02

Add IPFSEnabled policy to control IPFS feature

3292a97

Tests for ipfs policy

830a2df

yrliou force-pushed the ipfs_admin_policy branch from 9f83606 to 830a2df Compare October 30, 2020 15:03

mkarolin approved these changes Oct 30, 2020

View reviewed changes

yrliou mentioned this pull request Oct 30, 2020

Change the directory path of admin policy on linux brave/brave-browser#12426

Closed

yrliou merged commit f2f77a1 into master Oct 30, 2020

yrliou deleted the ipfs_admin_policy branch October 30, 2020 17:09

yrliou mentioned this pull request Jan 11, 2021

Admin policy for IPFS brave/brave-browser#11565

Closed

bbondy mentioned this pull request Jan 11, 2021

Native IPFS support in Brave brave/brave-browser#10220

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add IPFSEnabled policy to control IPFS feature #6966

Add IPFSEnabled policy to control IPFS feature #6966

yrliou commented Oct 27, 2020 •

edited

Loading

yrliou Oct 29, 2020 •

edited

Loading

yrliou Oct 29, 2020 •

edited

Loading

yrliou Oct 29, 2020

yrliou Oct 29, 2020

simonhong left a comment

yrliou commented Oct 30, 2020

bbondy left a comment

mkarolin left a comment

simonhong commented Oct 30, 2020

yrliou commented Oct 30, 2020

Add IPFSEnabled policy to control IPFS feature #6966

Add IPFSEnabled policy to control IPFS feature #6966

Conversation

yrliou commented Oct 27, 2020 • edited Loading

Submitter Checklist:

Test Plan:

Reviewer Checklist:

After-merge Checklist:

yrliou Oct 29, 2020 • edited Loading

Choose a reason for hiding this comment

yrliou Oct 29, 2020 • edited Loading

Choose a reason for hiding this comment

yrliou Oct 29, 2020

Choose a reason for hiding this comment

yrliou Oct 29, 2020

Choose a reason for hiding this comment

simonhong left a comment

Choose a reason for hiding this comment

yrliou commented Oct 30, 2020

bbondy left a comment

Choose a reason for hiding this comment

mkarolin left a comment

Choose a reason for hiding this comment

simonhong commented Oct 30, 2020

yrliou commented Oct 30, 2020

yrliou commented Oct 27, 2020 •

edited

Loading

yrliou Oct 29, 2020 •

edited

Loading

yrliou Oct 29, 2020 •

edited

Loading