Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix to desktop mode on tablets #6996

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Oct 30, 2020

We have to exclude whole function as previous fix did not work on
tablets.

Resolves brave/brave-browser#12419

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

We have to exclude whole function as previous fix did not work on
tablets.
@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Oct 30, 2020
@samartnik samartnik added this to the 1.18.x - Nightly milestone Oct 30, 2020
@samartnik samartnik self-assigned this Oct 30, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit 8a9941e into master Oct 30, 2020
@samartnik samartnik deleted the android_desktop_mode branch October 30, 2020 15:08
brave-builds pushed a commit that referenced this pull request Oct 30, 2020
brave-builds pushed a commit that referenced this pull request Oct 30, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Oct 30, 2020

Verification PASSED on both Samsung S10+ on Android 10 & Samsung Galaxy Tablet A on Android 10 using 1.18.23 CR 87.0.4280.27:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile page is shown in desktop mode when desktop site is disabled
3 participants