Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referer exception for geetest captchas #701

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Oct 19, 2018

The captcha fails unless referer is allowed

fix brave/brave-browser#1740

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

The captcha fails unless referer is allowed

fix brave/brave-browser#1740
@diracdeltas diracdeltas self-assigned this Oct 19, 2018
@diracdeltas diracdeltas requested review from pes10k and bbondy October 19, 2018 21:24
@diracdeltas
Copy link
Member Author

went thru manual test plan and verified unit tests on macOS

Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@bbondy
Copy link
Member

bbondy commented Oct 21, 2018

Nice! Thanks for fixing this, I've been meaning to.

@bbondy bbondy merged commit a57dc16 into brave:master Oct 21, 2018
bbondy added a commit that referenced this pull request Oct 21, 2018
Add referer exception for geetest captchas
bbondy added a commit that referenced this pull request Oct 21, 2018
Add referer exception for geetest captchas
bbondy added a commit that referenced this pull request Oct 21, 2018
Add referer exception for geetest captchas
@bbondy
Copy link
Member

bbondy commented Oct 21, 2018

master: a57dc16
0.57.x: aea4680
0.56.x: 7e4a261
0.55.x: 10f0dd0

@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
@kevinsimper
Copy link

How is this scalable adding domains manually? Especially when it is not transparent to users that there is a white-list where tracking can happen?

@aabedraba
Copy link

Bumping up @kevinsimper questions.
@pes10k any input on this?

@pes10k
Copy link
Contributor

pes10k commented May 10, 2020

Yep, our current system def doesn't scale, for all the reasons said above. The solution going forward (expect implementation to begin this week) is going to be this: brave/brave-browser#8696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should be able to solve binance captcha without allowing 3p cookies
5 participants