-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add referer exception for geetest captchas #701
Conversation
The captcha fails unless referer is allowed fix brave/brave-browser#1740
went thru manual test plan and verified unit tests on macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍
Nice! Thanks for fixing this, I've been meaning to. |
Add referer exception for geetest captchas
Add referer exception for geetest captchas
Add referer exception for geetest captchas
How is this scalable adding domains manually? Especially when it is not transparent to users that there is a white-list where tracking can happen? |
Bumping up @kevinsimper questions. |
Yep, our current system def doesn't scale, for all the reasons said above. The solution going forward (expect implementation to begin this week) is going to be this: brave/brave-browser#8696 |
The captcha fails unless referer is allowed
fix brave/brave-browser#1740
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: