Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fetching of IPFS resources #7068

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Allow fetching of IPFS resources #7068

merged 1 commit into from
Nov 6, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Nov 5, 2020

Resolves brave/brave-browser#12365

Not this is separate from this task which I'll work on next: brave/brave-browser#12546

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy requested review from diracdeltas and yrliou November 5, 2020 21:55
@bbondy bbondy requested a review from a team as a code owner November 5, 2020 21:55
@bbondy bbondy self-assigned this Nov 5, 2020
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bbondy
Copy link
Member Author

bbondy commented Nov 6, 2020

bypassing patch reviewer group review since this is not introducing a new patch and is building on top of an existing chromium_src.

@bbondy bbondy merged commit a66fd31 into master Nov 6, 2020
@bbondy bbondy deleted the ipfs-fetch branch November 6, 2020 17:56
@bbondy bbondy added this to the 1.18.x - Nightly milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch not working for ipfs and ipns scheme
3 participants