Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass isWindows property to GrantCaptcha #707

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 22, 2018

Fixes brave/brave-browser#1350

Without that property, captchas don't work as expected when resolution
is scaled.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Without that property, captchas don't work as expected when resolution
is scaled.
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't test, but merging as it looks good to me

@NejcZdovc NejcZdovc merged commit 733acb4 into master Oct 22, 2018
@NejcZdovc NejcZdovc deleted the rewards-captcha-fix branch October 22, 2018 18:22
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 22, 2018

master 733acb4
0.57.x d848188
0.56.x f7dfcc5
0.55.x ab67785

NejcZdovc added a commit that referenced this pull request Oct 22, 2018
Pass isWindows property to GrantCaptcha
NejcZdovc added a commit that referenced this pull request Oct 22, 2018
Pass isWindows property to GrantCaptcha
NejcZdovc added a commit that referenced this pull request Oct 22, 2018
Pass isWindows property to GrantCaptcha
mkarolin added a commit that referenced this pull request Oct 23, 2018
This reverts commit 733acb4, reversing
changes made to 88076d5.
mkarolin added a commit that referenced this pull request Oct 23, 2018
Revert "Merge pull request #707 from brave/rewards-captcha-fix"
mkarolin added a commit that referenced this pull request Oct 23, 2018
Revert "Merge pull request #707 from brave/rewards-captcha-fix"
mkarolin added a commit that referenced this pull request Oct 23, 2018
Revert "Merge pull request #707 from brave/rewards-captcha-fix"
mkarolin added a commit that referenced this pull request Oct 23, 2018
Revert "Merge pull request #707 from brave/rewards-captcha-fix"
NejcZdovc added a commit that referenced this pull request Oct 23, 2018
…-GrantCaptcha

Revert "Revert "Merge pull request #707 from brave/rewards-captcha-fix""
NejcZdovc added a commit that referenced this pull request Oct 23, 2018
…-GrantCaptcha

Revert "Revert "Merge pull request #707 from brave/rewards-captcha-fix""
NejcZdovc added a commit that referenced this pull request Oct 23, 2018
…-GrantCaptcha

Revert "Revert "Merge pull request #707 from brave/rewards-captcha-fix""
NejcZdovc added a commit that referenced this pull request Oct 23, 2018
…-GrantCaptcha

Revert "Revert "Merge pull request #707 from brave/rewards-captcha-fix""
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave rewards: captcha difficulty: win10 x64
3 participants