-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing "Add Card" tab with "Edit Cards" sub-tab [NTP] #7114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
049f2d9
to
2f9bc3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs some css changes IMO. Let me know if any questions
components/brave_new_tab_ui/components/default/editCards/assets/edit-icon.tsx
Outdated
Show resolved
Hide resolved
components/brave_new_tab_ui/components/default/editCards/style.ts
Outdated
Show resolved
Hide resolved
components/brave_new_tab_ui/components/default/editCards/style.ts
Outdated
Show resolved
Hide resolved
components/brave_new_tab_ui/components/default/editCards/style.ts
Outdated
Show resolved
Hide resolved
2f9bc3e
to
eb6e6ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just focus change needed otherwise 💯
components/brave_new_tab_ui/components/default/editCards/style.ts
Outdated
Show resolved
Hide resolved
eb6e6ce
to
be2661d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing
be2661d
to
8169346
Compare
Fixes brave/brave-browser#12625
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
Defined in issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.