-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include Android model by default #7200
Conversation
Are we intentionally only changing this in If we do want to change it in both places, then there is a bit more convoluted way that avoids patching. We could use |
The thing is that we DO want the model to show in brave://version so we can't patch any "lower" than the functions that construct the user agent string. |
I see, then we could replace the entire If that's undesirable, we could maybe use #define BRAVE_USER_AGENT true ? IncludeAndroidModel::Exclude : to patch after line 234 instead of doing a replacement patch. |
std::string os_info; | ||
base::StringAppendF(&os_info, "%s%s", GetUserAgentPlatform().c_str(), | ||
BuildOSCpuInfo(IncludeAndroidBuildNumber::Exclude, | ||
- IncludeAndroidModel::Include) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it maybe be better to override HardwareModelName
to some fixed value?
97da6c5
to
db2107c
Compare
CI failures are unrelated. |
Resolves brave/brave-browser#12638
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: