Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed BraveMainDelegateBrowserTest.PathOverride #7287

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 1, 2020

Removed because policy path is overridden again in browser test
to make sure that the machine policy directory is inside the clear profile.
See test_launcher_utils::OverrideUserDataDir().

F/U PR of #7277

Resolves brave/brave-browser#12426

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Disabled because policy path is overridden again in browser test
to make sure that the machine policy directory is inside the clear profile.
See test_launcher_utils::OverrideUserDataDir().
@simonhong simonhong requested a review from bsclifton December 1, 2020 07:29
@simonhong simonhong self-assigned this Dec 1, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong
Copy link
Member Author

Merged before finishing CI because this is just test code deletion.

@simonhong simonhong merged commit 2cf3be6 into master Dec 1, 2020
@simonhong simonhong deleted the remove_policy_path_override_test branch December 1, 2020 08:11
@simonhong simonhong added this to the 1.19.x - Nightly milestone Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the directory path of admin policy on linux
2 participants