Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.18.x - Uplift #7353 (today-optimize-fetch) #7374

Merged
merged 1 commit into from
Dec 9, 2020
Merged

1.18.x - Uplift #7353 (today-optimize-fetch) #7374

merged 1 commit into from
Dec 9, 2020

Conversation

petemill
Copy link
Member

@petemill petemill commented Dec 7, 2020

Brave Today: optimize fetching

#7353

@petemill petemill requested a review from a team December 7, 2020 22:21
@petemill petemill self-assigned this Dec 7, 2020
@kjozwiak kjozwiak added this to the 1.18.x - Release milestone Dec 8, 2020
@petemill petemill force-pushed the today-optimize-fix-1.18.x branch from 360093a to 0781cd4 Compare December 9, 2020 04:24
@petemill petemill force-pushed the today-optimize-fix-1.18.x branch from 0781cd4 to 8ea51df Compare December 9, 2020 04:28
@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2020

test-install failed on Win x64 as per https://ci.brave.com/job/pr-brave-browser-today-optimize-fix-1.18.x-windows/3/execution/node/275/log/. However, this is an intermittent failure and doesn't block uplift.

test-browser failed on macOS due to several reward failures as per https://ci.brave.com/job/pr-brave-browser-today-optimize-fix-1.18.x-macos/3/execution/node/254/log/. However, these are known intermittent issues and will be addressed via brave/brave-browser#12607, brave/brave-browser#12704 and brave/brave-browser#12605.

02:04:17  3 tests failed:
02:04:17      RewardsBrowserTest.ResetRewardsWithBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:374)
02:04:17      RewardsBrowserTest.UpholdLimitNoBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:397)
02:04:17      RewardsPromotionBrowserTest.ClaimViaPanel (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:201)

kjozwiak
kjozwiak approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7353 (comment).

@kjozwiak kjozwiak merged commit d75d8ca into 1.18.x Dec 9, 2020
@kjozwiak kjozwiak deleted the today-optimize-fix-1.18.x branch December 9, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@petemill petemill

Labels
None yet
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@petemill @kjozwiak