Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brave branding image used in win8 welcome page #741

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Add brave branding image used in win8 welcome page #741

merged 1 commit into from
Oct 26, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 26, 2018 •
edited
Loading

Issue: brave/brave-browser#1335

image

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong simonhong requested a review from bbondy October 26, 2018 04:38
@simonhong simonhong self-assigned this Oct 26, 2018
@simonhong simonhong mentioned this pull request Oct 26, 2018
Merged
16 tasks
@bbondy bbondy merged commit c5ea38d into master Oct 26, 2018
bbondy added a commit that referenced this pull request Oct 26, 2018
@bbondy
Merge pull request #741 from brave/remove_chrome_branding_on_win8_wel…
729031f 
…come_page

Add brave branding image used in win8 welcome page
bbondy added a commit that referenced this pull request Oct 26, 2018
@bbondy
Merge pull request #741 from brave/remove_chrome_branding_on_win8_wel…
9746c32 
…come_page

Add brave branding image used in win8 welcome page
@bbondy
Copy link
Member

bbondy commented Oct 26, 2018

master: c5ea38d
0.57.x: 729031f
0.56.x: 9746c32

@simonhong simonhong deleted the remove_chrome_branding_on_win8_welcome_page branch October 30, 2018 01:07
@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
0.56.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @bbondy