Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18.x - Uplift #7433 Brave Today: remove hint (scroll down arrow) animation #7435

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

petemill
Copy link
Member

@petemill petemill commented Dec 14, 2020

@petemill petemill added this to the 1.18.x - Release #2 milestone Dec 14, 2020
@petemill petemill requested a review from a team December 14, 2020 23:16
@petemill petemill self-assigned this Dec 14, 2020
@petemill petemill force-pushed the today-optimize-animation-1.18.x branch from 2976eb0 to ecf91ec Compare December 15, 2020 22:06
@kjozwiak
Copy link
Member

Restarting Linux via https://ci.brave.com/job/pr-brave-browser-today-optimize-animation-1.18.x-linux/3/ due to an error with the instance as per https://ci.brave.com/job/pr-brave-browser-today-optimize-animation-1.18.x-linux/2/execution/node/73/log/

17:12:42  An error occurred (InsufficientInstanceCapacity) when calling the StartInstances operation (reached max retries: 4): Insufficient capacity.

Restarting iOS via https://ci.brave.com/job/pr-brave-browser-today-optimize-animation-1.18.x-ios/3/ as build failed as per https://ci.brave.com/job/pr-brave-browser-today-optimize-animation-1.18.x-ios/2/execution/node/138/log/.

17:22:44  FAILED: obj/base/base/json_writer.o 

@bsclifton bsclifton force-pushed the today-optimize-animation-1.18.x branch from ecf91ec to 73c15f6 Compare December 16, 2020 20:30
@kjozwiak
Copy link
Member

test-browser failed on macOS due to several reward failures as per https://ci.brave.com/job/pr-brave-browser-today-optimize-animation-1.18.x-macos/3/execution/node/202/log/. However, these are known intermittent issues and have been filed via GH. Doesn't block uplift.

17:39:00  3 tests failed:
17:39:00      RewardsBrowserTest.UpholdLimitNoBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:397)
17:39:00      RewardsPromotionBrowserTest.ClaimViaPanel (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:201)
17:39:00      RewardsPromotionBrowserTest.PromotionRemovedFromEndpoint (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:230)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7433 (comment).

@kjozwiak kjozwiak merged commit 0a28c08 into 1.18.x Dec 17, 2020
@kjozwiak kjozwiak deleted the today-optimize-animation-1.18.x branch December 17, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants