Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable reset report uploader and hide UI #745

Merged
merged 4 commits into from
Oct 30, 2018
Merged

Disable reset report uploader and hide UI #745

merged 4 commits into from
Oct 30, 2018

Conversation

pilgrim-brave
Copy link
Contributor

Fixes brave/brave-browser#1844

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@pilgrim-brave pilgrim-brave self-assigned this Oct 26, 2018
@pilgrim-brave pilgrim-brave requested a review from bbondy October 26, 2018 13:27
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_disable_reset_report_uploader branch from 3e0a6a6 to 27606af Compare October 30, 2018 17:05
@bbondy bbondy merged commit 22db3e8 into master Oct 30, 2018
@bsclifton bsclifton deleted the mpilgrim_disable_reset_report_uploader branch November 5, 2018 18:49
@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@simonhong
Merge pull request #745 from brave/refactor_mac_app_name_generation
763c849 
Cleanup: Move mac app name generation from start.js to config.js
petemill pushed a commit that referenced this pull request Jul 27, 2020
@simonhong
Merge pull request #745 from brave/refactor_mac_app_name_generation
4df26dd 
Cleanup: Move mac app name generation from start.js to config.js
petemill pushed a commit that referenced this pull request Jul 28, 2020
@simonhong
Merge pull request #745 from brave/refactor_mac_app_name_generation
0751d1b 
Cleanup: Move mac app name generation from start.js to config.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
0.58.x - Release
Development

Successfully merging this pull request may close these issues.

Disable reset report uploader
2 participants
@pilgrim-brave @bbondy