Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables Wayback Machine infobar on Wayback Machine URLs #7506

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Dec 30, 2020

Fixes brave/brave-browser#13306

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Defined in issue

@ryanml ryanml requested a review from simonhong December 30, 2020 00:27
@ryanml ryanml self-assigned this Dec 30, 2020
@ryanml
Copy link
Contributor Author

ryanml commented Dec 30, 2020

CI failures unrelated

@ryanml ryanml added this to the 1.20.x - Nightly milestone Dec 30, 2020
@ryanml ryanml merged commit a548086 into master Dec 30, 2020
@ryanml ryanml deleted the fix-13306 branch December 30, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not suggest a Wayback Machine lookup if the 404 is from Wayback Machine itself
2 participants