Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes smallvec rust vulnerability. #7551

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Fixes smallvec rust vulnerability. #7551

merged 2 commits into from
Jan 11, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jan 8, 2021

Fixes brave/brave-browser#13446

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Jan 8, 2021
This version fixes smallvec vulnerability.
@mkarolin mkarolin marked this pull request as ready for review January 9, 2021 17:48
@mkarolin mkarolin requested a review from iefremov as a code owner January 9, 2021 17:48
@mkarolin mkarolin requested a review from antonok-edm January 9, 2021 17:49
@bsclifton
Copy link
Member

CI looks good; no errors except for known issue w/ browser test on macOS (brave/brave-browser#12605)

Good to merge 😄 Does this need uplift?

@bsclifton bsclifton merged commit d566fc3 into master Jan 11, 2021
@bsclifton bsclifton deleted the maxk-fix-smallvec branch January 11, 2021 07:33
@bsclifton bsclifton added this to the 1.20.x - Nightly milestone Jan 11, 2021
mkarolin pushed a commit that referenced this pull request Jan 11, 2021
Fixes smallvec rust vulnerability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix smallvec rust dependency vulnerability.
4 participants