Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rewards monthly report drop-down not updating #7615

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#13590

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open browser with a profile that has several months of transaction activity.
  • Navigate to the rewards page.
  • Click on "View Monthly Statement for Details"
    • Verify that the current month is displayed in the drop down.
    • Verify that several monthly are displayed in the drop down options.
  • Select a different month.
    • Verify the drop down's currently selected month has changed.
    • Verify that the currently selected month's data is displayed in the drop-down.
  • Close the monthly report modal.
  • Click on "View Monthly Statement for Details" again.
    • Verify that the current month is displayed in the drop down.

@zenparsing zenparsing requested a review from a team as a code owner January 15, 2021 17:55
@zenparsing zenparsing self-assigned this Jan 15, 2021
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monthly Contribution Statement dropdown always shows latest month, even when another month is selected
2 participants