Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13464: Unrestrict referrer hiding for top-level navigations. (uplift to 1.19.x) #7639

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 18, 2021

Uplift of #7591
Fix brave/brave-browser#13464

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested review from iefremov and a team as code owners January 18, 2021 09:44
@brave-builds brave-builds requested a review from a team January 18, 2021 09:44
@brave-builds brave-builds self-assigned this Jan 18, 2021
@brave-builds brave-builds added this to the 1.19.x - Release milestone Jan 18, 2021
@kjozwiak
Copy link
Member

test-browser failed on Linux due to SearchEngineProviderP3ATest.DefaultSearchEngineP3A failing as per https://ci.brave.com/job/pr-brave-browser-pr7591_ie_referrer_cap_1.19.x-linux/1/execution/node/201/log/. However, this is a known intermittent issue as per brave/brave-browser#13057 and doesn't block uplift.

06:11:25  1 test failed:
06:11:25      SearchEngineProviderP3ATest.DefaultSearchEngineP3A (../../brave/browser/search_engines/search_engine_tracker_browsertest.cc:30)

Restarting macOS as it failed build as per https://ci.brave.com/job/pr-brave-browser-pr7591_ie_referrer_cap_1.19.x-macos/1/execution/node/154/log/. Looks like it was interrupted.

08:54:20  Sending interrupt signal to process
08:54:20  ninja: build stopped: interrupted by user.
08:54:20  script returned exit code 143

@kjozwiak
Copy link
Member

test-browser failed on macOS due to RewardsPromotionBrowserTest.ClaimViaPanel failing as per https://ci.brave.com/job/pr-brave-browser-pr7591_ie_referrer_cap_1.19.x-macos/2/execution/node/202/log/. However, this is a known intermittent issue as per brave/brave-browser#12605 and doesn't block uplift.

19:15:45  1 test failed:
19:15:45      RewardsPromotionBrowserTest.ClaimViaPanel (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:204)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.19.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7591 (comment).

@kjozwiak kjozwiak merged commit 0ef02a0 into 1.19.x Jan 19, 2021
@kjozwiak kjozwiak deleted the pr7591_ie_referrer_cap_1.19.x branch January 19, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants