Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix for crash on updating home button state (uplift to 1.20.x) #7671

Merged
merged 1 commit into from
Jan 22, 2021
Merged

[Android] Fix for crash on updating home button state (uplift to 1.20.x) #7671

merged 1 commit into from
Jan 22, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 20, 2021 •
edited by kjozwiak
Loading

Uplift of #7668
Resolves brave/brave-browser#13680

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team January 20, 2021 17:51
@brave-builds brave-builds self-assigned this Jan 20, 2021
@brave-builds brave-builds added this to the 1.20.x - Beta milestone Jan 20, 2021
@samartnik samartnik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jan 20, 2021
kjozwiak
kjozwiak approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.20.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 778fba2 into 1.20.x Jan 22, 2021
@kjozwiak kjozwiak deleted the pr7668_android_home_button_state_crash_1.20.x branch January 22, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @samartnik @brave-browser-releases