Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set P3A enabled for existing users #7765

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Set P3A enabled for existing users #7765

merged 2 commits into from
Feb 2, 2021

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#13871

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 1, 2021
@deeppandya deeppandya added this to the 1.21.x - Nightly milestone Feb 1, 2021
@deeppandya deeppandya self-assigned this Feb 1, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@deeppandya deeppandya merged commit 460e3bc into master Feb 2, 2021
@deeppandya deeppandya deleted the issue_13871 branch February 2, 2021 14:55
brave-builds pushed a commit that referenced this pull request Feb 2, 2021
@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2021

Verification passed on OnePlus 6T with Android 10 running 1.21.41 x64 Nightly build

  • Verified upgrading from 1.20.39 (Nightly) to 1.21.39(Nightly) shows the P3A modal but is not enabled by default
  • Background the app and relaunch shows P3A setting disabled under Privacy settings
  • Verified upgrading from 1.20.39 (Nightly) to 1.21.41(Nightly) shows the P3A modal and is enabled by default
  • Background the app and relaunch shows P3A setting enabled under Privacy settings

@deeppandya deeppandya changed the title Fix #13871 Set P3A enabled for existing users Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set P3A enabled for existing users
4 participants