Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording on brave rewards sponsored image notification #7786

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Feb 2, 2021

Resolves brave/brave-browser#13397

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Sponsored image notification should match screenshot at brave/brave-browser#13397 (comment)

@zenparsing
Copy link
Collaborator Author

CI:

  • macOS failed on unrelated RewardsPromotionBrowserTest.ClaimViaPanel
  • Windows failed on unrelated AdBlockServiceTest.CosmeticFilteringProtect1p

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit 21daa28 into master Feb 3, 2021
@zenparsing zenparsing deleted the ksmith-br-widget-wording branch February 3, 2021 18:52
@zenparsing zenparsing added this to the 1.21.x - Nightly milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the wording on the BR widget
2 participants