Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Add set default browser modal (Uplift to 1.20.x) #7825

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Revert Add set default browser modal (Uplift to 1.20.x) #7825

merged 1 commit into from
Feb 4, 2021

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Feb 4, 2021 •
edited
Loading

Revert uplift done with #7756
Unfixes brave/brave-browser#12390 for 1.20

Reason being that translations aren't being pulled for this release (see brave/brave-browser#13958). They will be pulled for 1.21

@bsclifton
Revert "Merge pull request #7756 from brave/add_set_default_browser_m…
6914769 
…odal_android_1.20.x"

This reverts commit df9cb48, reversing
changes made to 2343348.
@bsclifton bsclifton added this to the 1.20.x - Release milestone Feb 4, 2021
@bsclifton bsclifton requested a review from a team February 4, 2021 17:58
@bsclifton bsclifton self-assigned this Feb 4, 2021
@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label Feb 4, 2021
@bsclifton bsclifton merged commit cdc4feb into 1.20.x Feb 4, 2021
@bsclifton bsclifton deleted the bsc-revert-def-browser-1.20.x branch February 4, 2021 18:05
@bsclifton bsclifton mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bsclifton bsclifton

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging this pull request may close these issues.
1 participant
@bsclifton