Add ENS support #8125
Merged
Add ENS support #8125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
force-pushed
the
ens_support_rebase
branch
from
3901583 to
55a4d12
Compare
yrliou
force-pushed
the
ens_support_rebase
branch
from
a72dfcb to
49230e2
Compare
bbondy
reviewed
Mar 6, 2021
| <settings-dropdown-menu id="ensResolveMethodType" | ||
| pref="{{prefs.brave.ens.resolve_method}}" | ||
| menu-options="[[ensResolveMethod_]]"> | ||
| </div> |
There was a problem hiding this comment.
In a separate PR perhaps, but I wonder if these should go under the wallet settings. As it is now it's in the extensions settings which doesn't seem right. I know it's not really wallet, but it's along the same lines for people that care about these options. @jamesmudgett thoughts?
bbondy
reviewed
Mar 6, 2021
| if (base::EndsWith(host, unstoppable_domains::kCryptoDomain)) { | ||
| *suffix_length = strlen(unstoppable_domains::kCryptoDomain) - 1; | ||
| if (base::EndsWith(host, decentralized_dns::kCryptoDomain)) { | ||
| *suffix_length = strlen(decentralized_dns::kCryptoDomain) - 1; |
There was a problem hiding this comment.
nit: I know it's not from this PR, but at some point it would be good to rename this to kUnstoppableDomain because crypto is overloaded enough already :)
There was a problem hiding this comment.
Personally I felt kCryptoDomain is more straightforward for “.crypto” than kUnstoppableDomain, so I'll keep it for now.
bbondy
approved these changes
Mar 6, 2021
yrliou
force-pushed
the
ens_support_rebase
branch
from
49230e2 to
513c102
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14477
First two commits are just renaming things & formatting after that.
Main commit for adding ENS support is c24b31e.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Same as #7702, just change brave.crypto to brantly.eth.