Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled DCHECKs in tests that run on CI. #8194

Merged
merged 11 commits into from
Mar 16, 2021
Merged

Enabled DCHECKs in tests that run on CI. #8194

merged 11 commits into from
Mar 16, 2021

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Mar 9, 2021

Resolves brave/devops#4616

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik requested a review from mihaiplesa as a code owner March 9, 2021 16:13
@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Mar 9, 2021
@wknapik wknapik added CI/skip-macos-x64 Do not run CI builds for macOS x64 and removed CI/skip-linux labels Mar 9, 2021
@wknapik wknapik changed the title Testing. Enabled DCHECKs in tests that run on CI. Mar 10, 2021
@iefremov iefremov requested a review from bridiver March 10, 2021 12:25
@wknapik wknapik removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Mar 10, 2021
@iefremov
Copy link
Contributor

@wknapik is this one ready?

@wknapik
Copy link
Collaborator Author

wknapik commented Mar 12, 2021

@iefremov indeed, ready for review.

@mihaiplesa mihaiplesa added this to the 1.23.x - Nightly milestone Mar 15, 2021
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.js should specify the default configurations and exceptions to those configuration should be specified in npm config, not the other way around.

@wknapik wknapik merged commit 697587f into master Mar 16, 2021
@wknapik wknapik deleted the wknapik-dcheck branch March 16, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants