Treat decentralized DNS servers as available before first probe is completed #8212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
reviewed
Mar 10, 2021
| #include "net/dns/context_host_resolver.h" | ||
|
|
||
| #define ResolveContext BraveResolveContext | ||
| #include "../../../../net/dns/host_resolver.cc" |
mkarolin
reviewed
Mar 10, 2021
|
|
||
| #define GetDohServerAvailability virtual GetDohServerAvailability | ||
| #define NumAvailableDohServers virtual NumAvailableDohServers | ||
| #define BRAVE_RESOLVE_CONTEXT_H friend class BraveResolveContext; |
There was a problem hiding this comment.
Nit: could follow the format:
#define BRAVE_RESOLVE_CONTEXT_H\ private: \ friend class BraveResolveContext;
mkarolin
approved these changes
Mar 10, 2021
yrliou
force-pushed
the
fix_before_first_probe
branch
from
c24010f to
7f9ef57
Compare
bbondy
approved these changes
Mar 11, 2021
|
post-init has unrelated audit-dep failure |
yrliou
added a commit
that referenced
this pull request
Mar 18, 2021
Treat decentralized DNS servers as available before first probe is completed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14513
This PR handles the case that DNS resolution failed because of falling back to non-secure DNS servers before the first probe of DoH server is completed and marked as available to use.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: