Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ipfs links through x-ipfs-path and dnslink values #8254

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 15, 2021

Resolves brave/brave-browser#14657

Tweak the badge logic to make things work on all types of gateways (path, subdomain, dnslink):

  • read content path value from x-ipfs-path header

  • remove first slash and replace second one with ://

  • append any ?queries or #fragments present in the original URL## Submitter Checklist:

  • dnslink= keeps old logic and navigates to ipns://hostname

  • I confirm that no security/privacy review is needed, or that I have requested one

  • There is a ticket for my issue

  • Used Github auto-closing keywords in the PR description above

  • Wrote a good PR/commit description

  • [] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue

  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint

  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Set ipfs mode to use local node
  • Navigate by pages: https://en-wikipedia--on--ipfs-org.ipns.dweb.link/wiki/
  • Click by anchors on the page to jump to the end of a page
  • Check that everything after # parameter in url bar will be migrated if you click the ipfs button
  • Check that dnslink= keeps old logic and navigates to ipns://hostname

@spylogsster spylogsster self-assigned this Mar 15, 2021
@spylogsster spylogsster force-pushed the ipfs-badge-public-gateways branch 2 times, most recently from bb91967 to 9161e7e Compare March 15, 2021 17:22
@spylogsster spylogsster requested a review from bbondy March 15, 2021 17:24
@spylogsster spylogsster force-pushed the ipfs-badge-public-gateways branch 3 times, most recently from b75c026 to 018e7ec Compare March 16, 2021 10:09
@spylogsster spylogsster merged commit 323b14f into master Mar 18, 2021
@spylogsster spylogsster deleted the ipfs-badge-public-gateways branch March 18, 2021 06:14
@spylogsster spylogsster added this to the 1.24.x - Nightly milestone Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS badge broken on public gateways
2 participants