Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Ads are not shown if the browser window did not enter the background and then become active #8255

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 15, 2021

Resolves brave/brave-browser#14736

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#14736

@tmancey tmancey requested a review from moritzhaller March 15, 2021 15:59
@tmancey tmancey self-assigned this Mar 15, 2021
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/14736 branch 12 times, most recently from e4bdf8e to d6ce85e Compare March 17, 2021 08:12
@tmancey
Copy link
Collaborator Author

tmancey commented Mar 17, 2021

CI failed due to unrelated browser tests and audit deps

@tmancey tmancey merged commit 24930e8 into master Mar 17, 2021
@tmancey tmancey deleted the issues/14736 branch March 17, 2021 12:41
@tmancey tmancey added this to the 1.24.x - Nightly milestone Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Ads are not shown if the browser window did not enter the background and then become active
2 participants