Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14740
Logic within upstream UA building code appends " Mobile" to the UA at a specific place if
kUseMobileUserAgent
switch is on, which it is for the Android build. This confused our test for whether the UA had been overridden by something we wanted to respect (like a command line flag or a user-modifiable runtime flag), resulting in never farbling the UA on Android. This fix replicates thekUseMobileUserAgent
logic withinBraveContentBrowserClient
so that we properly minimize/farble the UA on all platforms, while still respecting relevant commandline/runtime flags.Includes a new test to ensure that we are sending our minimized UA over the wire when
kUseMobileUserAgent
switch is on. (For Android, this means no build number or model name.)Also migrates UA farbling tests to
EvalJs
.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: