Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Do not automatically initialize ledger to limit outbound calls #8347

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Mar 24, 2021

Refs brave/brave-ios#3410

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added feature/rewards CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 24, 2021
@kylehickinson kylehickinson added this to the 1.24.x - Nightly milestone Mar 24, 2021
@kylehickinson kylehickinson requested review from Brandon-T, mariospr and a team March 24, 2021 16:20
@kylehickinson kylehickinson self-assigned this Mar 24, 2021
@kylehickinson kylehickinson removed the request for review from mariospr March 24, 2021 16:23
@jumde jumde self-requested a review March 25, 2021 18:18
Copy link
Contributor

@jumde jumde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kylehickinson kylehickinson force-pushed the ios-limit-rewards-calls branch from 6fc7231 to 3fcf72f Compare April 7, 2021 20:08
@kylehickinson
Copy link
Collaborator Author

post-init was linter on ignored files?
pre-init was some unrelated issue in pylint?

@kylehickinson kylehickinson merged commit 4c1f1bc into master Apr 8, 2021
@kylehickinson kylehickinson deleted the ios-limit-rewards-calls branch April 8, 2021 14:38
brave-builds pushed a commit that referenced this pull request Apr 8, 2021
brave-builds pushed a commit that referenced this pull request Apr 8, 2021
kylehickinson added a commit that referenced this pull request Jan 4, 2024
…8347)

This cleans up the duplicate drag interactions as well as fixes the bug where you could no longer move the caret inside of the url bar text field. It also restores a missed delegate method and removes the drop delegate on the active text field so as to not crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants