Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deep properties #8365

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Migrate deep properties #8365

merged 1 commit into from
Mar 29, 2021

Conversation

spylogsster
Copy link
Contributor

Resolves brave/brave-browser#14923

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • [] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open devtools console for brave://ipfs page and remove some properties from saved object in Application tab
  • Refresh page
  • Page should be loaded correctly and properties are restored as default values

@spylogsster spylogsster requested a review from bbondy March 26, 2021 11:16
@spylogsster spylogsster self-assigned this Mar 26, 2021
@spylogsster spylogsster force-pushed the improve-migration-ipfs-storage branch from f54b55d to fc88d17 Compare March 26, 2021 11:16
@spylogsster spylogsster requested a review from yrliou March 26, 2021 13:03
@spylogsster spylogsster force-pushed the improve-migration-ipfs-storage branch from fc88d17 to e2e0d7d Compare March 26, 2021 15:41
@spylogsster spylogsster merged commit c869b1a into master Mar 29, 2021
@spylogsster spylogsster deleted the improve-migration-ipfs-storage branch March 29, 2021 14:04
@spylogsster spylogsster added this to the 1.24.x - Nightly milestone Mar 29, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Ref ##8297: Update brave-core to 1.60.113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave://ipfs appears blank
2 participants