Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import local file to ipfs #8423

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Import local file to ipfs #8423

merged 2 commits into from
Apr 19, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Apr 2, 2021

Resolves brave/brave-browser#15078

  • Added IPFS submenu to main app menu
  • Added local file import worker to upload local files to ipfs

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Import any local file to ipfs via app menu items
  • Shareable link should allow to download a file, link resolving can take long time (up to 10minutes)

@spylogsster spylogsster requested a review from a team as a April 2, 2021 16:37
@spylogsster spylogsster force-pushed the import-local-file branch 2 times, most recently from 380574a to 99749a4 Compare April 2, 2021 17:18
@spylogsster spylogsster force-pushed the import-to-ipfs branch 2 times, most recently from 7f62b01 to b48bbef Compare April 2, 2021 17:42
@spylogsster spylogsster force-pushed the import-local-file branch 2 times, most recently from 78f6fac to 248b3d3 Compare April 2, 2021 17:55
@spylogsster spylogsster requested a review from bbondy April 2, 2021 18:12
@spylogsster spylogsster changed the title Upload local file Import local file to ipfs Apr 2, 2021
@spylogsster spylogsster force-pushed the import-to-ipfs branch 9 times, most recently from 4b10ce9 to 860e418 Compare April 6, 2021 12:12
@spylogsster spylogsster force-pushed the import-local-file branch 4 times, most recently from 22930d9 to 0d82201 Compare April 6, 2021 13:31
@spylogsster spylogsster force-pushed the import-to-ipfs branch 3 times, most recently from e9e28e3 to beee648 Compare April 15, 2021 11:59
Base automatically changed from import-to-ipfs to master April 16, 2021 14:36
app/brave_generated_resources.grd Outdated Show resolved Hide resolved
browser/ipfs/ipfs_tab_helper.cc Outdated Show resolved Hide resolved
browser/ipfs/ipfs_tab_helper.h Show resolved Hide resolved
components/ipfs/ipfs_file_import_worker.h Outdated Show resolved Hide resolved
components/ipfs/ipfs_file_import_worker.h Outdated Show resolved Hide resolved
browser/ui/toolbar/brave_app_menu_model.cc Outdated Show resolved Hide resolved
browser/ui/toolbar/brave_app_menu_model.cc Outdated Show resolved Hide resolved
browser/ui/toolbar/brave_app_menu_model.cc Show resolved Hide resolved
components/ipfs/ipfs_file_import_worker.cc Outdated Show resolved Hide resolved
components/ipfs/ipfs_file_import_worker.cc Outdated Show resolved Hide resolved
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to use a separate commit this time, thanks! :)

browser/ipfs/ipfs_tab_helper.h Outdated Show resolved Hide resolved
browser/ui/brave_pages.cc Outdated Show resolved Hide resolved
components/ipfs/ipfs_file_import_worker.cc Outdated Show resolved Hide resolved
components/ipfs/ipfs_file_import_worker.cc Outdated Show resolved Hide resolved
components/ipfs/ipfs_file_import_worker.cc Outdated Show resolved Hide resolved
components/ipfs/ipfs_file_import_worker.h Show resolved Hide resolved
components/ipfs/ipfs_link_import_worker.cc Outdated Show resolved Hide resolved
components/ipfs/ipfs_text_import_worker.cc Outdated Show resolved Hide resolved
browser/ui/brave_pages.h Outdated Show resolved Hide resolved
@spylogsster spylogsster force-pushed the import-local-file branch 10 times, most recently from 1568522 to 7bd7789 Compare April 19, 2021 11:45
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import local files to ipfs
2 participants