-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import local file to ipfs #8423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spylogsster
force-pushed
the
import-to-ipfs
branch
from
April 2, 2021 17:12
675e47c
to
d1f367b
Compare
spylogsster
force-pushed
the
import-local-file
branch
2 times, most recently
from
April 2, 2021 17:18
380574a
to
99749a4
Compare
spylogsster
force-pushed
the
import-to-ipfs
branch
2 times, most recently
from
April 2, 2021 17:42
7f62b01
to
b48bbef
Compare
spylogsster
force-pushed
the
import-local-file
branch
2 times, most recently
from
April 2, 2021 17:55
78f6fac
to
248b3d3
Compare
spylogsster
force-pushed
the
import-to-ipfs
branch
from
April 2, 2021 17:58
b48bbef
to
15b1010
Compare
spylogsster
force-pushed
the
import-local-file
branch
from
April 2, 2021 17:58
248b3d3
to
757bb92
Compare
spylogsster
force-pushed
the
import-to-ipfs
branch
from
April 2, 2021 18:38
15b1010
to
cf1e851
Compare
spylogsster
force-pushed
the
import-local-file
branch
from
April 2, 2021 18:42
757bb92
to
e59d442
Compare
spylogsster
force-pushed
the
import-to-ipfs
branch
from
April 2, 2021 19:44
cf1e851
to
ec7d10e
Compare
spylogsster
force-pushed
the
import-local-file
branch
from
April 2, 2021 19:46
e59d442
to
055a4b6
Compare
spylogsster
force-pushed
the
import-to-ipfs
branch
9 times, most recently
from
April 6, 2021 12:12
4b10ce9
to
860e418
Compare
spylogsster
force-pushed
the
import-local-file
branch
4 times, most recently
from
April 6, 2021 13:31
22930d9
to
0d82201
Compare
spylogsster
force-pushed
the
import-to-ipfs
branch
3 times, most recently
from
April 15, 2021 11:59
e9e28e3
to
beee648
Compare
spylogsster
force-pushed
the
import-local-file
branch
from
April 15, 2021 12:06
a31b741
to
b6f5fbd
Compare
spylogsster
force-pushed
the
import-local-file
branch
from
April 16, 2021 15:28
b6f5fbd
to
1b97042
Compare
yrliou
reviewed
Apr 16, 2021
spylogsster
force-pushed
the
import-local-file
branch
from
April 16, 2021 18:41
488ddb9
to
f00892c
Compare
yrliou
reviewed
Apr 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to use a separate commit this time, thanks! :)
yrliou
reviewed
Apr 16, 2021
spylogsster
force-pushed
the
import-local-file
branch
10 times, most recently
from
April 19, 2021 11:45
1568522
to
7bd7789
Compare
spylogsster
force-pushed
the
import-local-file
branch
from
April 19, 2021 12:33
7bd7789
to
d598013
Compare
spylogsster
force-pushed
the
import-local-file
branch
from
April 19, 2021 14:18
d598013
to
545b367
Compare
yrliou
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#15078
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: