Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.23.x release (1.23.x). #8498

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#14956
Uplift from #8494

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team April 10, 2021 02:26
@mkarolin mkarolin self-assigned this Apr 10, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Apr 12, 2021

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-maxk-release-1.23.x-l10n-1.23.x-macos/1/execution/node/242/log/ & https://ci.brave.com/job/pr-brave-browser-maxk-release-1.23.x-l10n-1.23.x-macos/1/execution/node/245/log/. However, these failures are unrelated to this specific PR.

00:55:29  5 tests crashed:
00:55:29      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
00:55:29      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
00:55:29      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
00:55:29      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
00:55:29      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

Going to restart Linux just in case as BraveStatsUpdaterBrowserTest.StatsUpdaterMigration failed which isn't a common failure.

@kjozwiak kjozwiak added this to the 1.23.x - Release milestone Apr 12, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers. QA will run through the changes once we get a new 1.23.x RC.

@kjozwiak kjozwiak merged commit 3d8fc6b into 1.23.x Apr 12, 2021
@kjozwiak kjozwiak deleted the maxk-release-1.23.x-l10n-1.23.x branch April 12, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants