-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves brave/brave-browser#15251 #8558
Resolves brave/brave-browser#15251 #8558
Conversation
This looks good to me @rahulsnkr -- thanks for picking this up! I don't know if these strings exist anywhere else; do you know/mind giving a review, @AlexeyBarabash ? |
Thanks @rahulsnkr ! English is not my native language, so I can't properly review it, I will add @brave/design team to check that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if @brave/design ultimately wants to change from delete
to remove
, but the English usage side LGTM.
Yup, I cleared the text change with @karenkliu before filing (so as to match the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert app/resources/brave_generated_resources_en-GB.xtb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4065544
to
e9f0ba0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
@rahulsnkr could you please merge it? |
Apologies @jsecretan, accidentally re-requested a review. @AlexeyBarabash I can't merge yet since @karenkliu and @jamesmudgett are yet to approve. |
Once @stephendonner agreed the changes with @karenkliu then I remove @karenkliu and @jamesmudgett from reviewers. |
@jsecretan could you please approve again? |
I still don't see the option to merge since I don't have write access to the repo @AlexeyBarabash |
oh, sorry, @rahulsnkr, I didn't know that. Then I will merge it. Thanks a lot for the contribution. |
Resolves brave/brave-browser#15251
Fixes typos in the remove-device prompt text when a device is removed from the sync chain.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: