Toned down interstitials for top-level blocking. #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need sub issue from brave/brave-browser#15189 for this partial fix. |
fmarier
requested changes
Apr 22, 2021
| </message> | ||
| <message name="IDS_DOMAIN_BLOCK_PRIMARY_PARAGRAPH" desc="Main paragraph of domain block interstitial page."> | ||
| Brave has prevented the following site from loading: | ||
| </message> | ||
| <message name="IDS_DOMAIN_BLOCK_EXPLANATION" desc="Second paragraph of domain block interstitial page."> | ||
| This site may be fraudulent, bounce you between various sites to set tracking cookies, or perform other privacy invasive actions. | ||
| This page may be trying to link some of your personal data with a cookie before taking you to your intended destination. You can choose to allow this potential privacy leak and proceed to the next page, or you can block this tracking attempt by going back to the previous page. |
There was a problem hiding this comment.
Let's use @karenkliu 's wording (see the screenshots instead of the GitHub comments) instead of what I proposed.
There was a problem hiding this comment.
Sorry, I should have commented to that effect on the issue.
There was a problem hiding this comment.
@fmarier the heading as well?
mkarolin
force-pushed
the
maxk-fix-domain-block-interstitial
branch
from
2809e82 to
d227118
Compare
|
Switched "Proceed" button to be the default.
|
Also, switched to Chromium's information (i) icon instead of the red exclamation point. Fixes brave/brave-browser#15433
mkarolin
force-pushed
the
maxk-fix-domain-block-interstitial
branch
from
d227118 to
f6335b3
Compare
fmarier
approved these changes
Apr 22, 2021
|
CI browser test failures on Linux and MacOS are known and unrelated to this PR. |
brave-builds
pushed a commit
that referenced
this pull request
Apr 22, 2021
7 tasks
mkarolin
pushed a commit
that referenced
this pull request
Apr 26, 2021
|
Verification PASSED on
|
kylehickinson
pushed a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Fixes brave/brave-browser#15433
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: