-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] reorganises Settings and Privacy settings, sets shields global prefs #8790
Conversation
android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/settings/BraveWebrtcPolicyPreference.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/settings/BraveDialogPreference.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/settings/BraveDialogPreference.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/settings/BravePreferenceDialogFragment.java
Outdated
Show resolved
Hide resolved
@SmallTest | ||
public void testPrivacySandboxDefaultIsDisabled() { | ||
TestThreadUtils.runOnUiThreadBlocking(() -> { | ||
if (PrivacySandboxBridge.isPrivacySandboxSettingsFunctional()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we decided to check if it false here instead of this clause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Resolves brave/brave-browser#7487
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please check the latest figma file included in the issue for the UI/UX changes:
Probably all (or most) settings will need to be re-checked just to be sure.
Please look for any missing settings or things that might not make sense.
The way the settings bellow work has been changed :
Search engines
Testing for the new Brave shields & privacy settings -> shields global defaults:
-Block cookies
-Fingerprinting -test plan to be determined
Testing for Brave shields & privacy settings -> Clear browsing data - Clear data on exit
1.When it's on, after the app is closed (swiped out) re-opening it should result in the following data to be wiped (it wipes it for the whole history):
It does not closes open tabs (for that there is the separate close all tabs on exit setting that can be used in combination)
Testing for Brave shields & privacy settings -> Other - WebRTC