Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] reorganises Settings and Privacy settings, sets shields global prefs #8790

Merged
merged 2 commits into from
May 19, 2021

Conversation

alexsafe
Copy link
Contributor

Resolves brave/brave-browser#7487

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please check the latest figma file included in the issue for the UI/UX changes:

  • all settings found in figma should appear in the exact order in the app
  • all icons should correspond to the right setting
  • any other inconsistencies

Probably all (or most) settings will need to be re-checked just to be sure.
Please look for any missing settings or things that might not make sense.

The way the settings bellow work has been changed :

Search engines

  • opens a new preference screen where you can choose the default search engine for private and standard tabs
  • the behaviour after choosing should be as before and reflect in the app's behaviour

Testing for the new Brave shields & privacy settings -> shields global defaults:

  • Block ads & trackers - set to aggressive
  1. On duckduckgo search for something like "samsung galaxy s10"
  2. Check the result of the search:
  • there should be no hits that contain Ads
  • Block ads & trackers - set to standard or allow
  1. Open a new tab and repeat the steps above. The result should contain a few Ads hits in the beginning of the result list

-Block cookies

  • block all cookies:
    • Open a new tab and try to log on facebook. you shouldn't be able log in
  • block cross-site cookies and allow should allow you to login

-Fingerprinting -test plan to be determined

  • Block scripts -on should show a blank page on Facebook

Testing for Brave shields & privacy settings -> Clear browsing data - Clear data on exit

1.When it's on, after the app is closed (swiped out) re-opening it should result in the following data to be wiped (it wipes it for the whole history):

  • browsing history
  • cookies
  • passwords
  • forms
  • site settings
  • cache
    It does not closes open tabs (for that there is the separate close all tabs on exit setting that can be used in combination)

Testing for Brave shields & privacy settings -> Other - WebRTC

@alexsafe alexsafe marked this pull request as ready for review May 17, 2021 22:46
@alexsafe alexsafe requested a review from samartnik May 17, 2021 22:46
@SmallTest
public void testPrivacySandboxDefaultIsDisabled() {
TestThreadUtils.runOnUiThreadBlocking(() -> {
if (PrivacySandboxBridge.isPrivacySandboxSettingsFunctional()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we decided to check if it false here instead of this clause.

@alexsafe alexsafe added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 19, 2021
@alexsafe alexsafe added this to the 1.26.x - Nightly milestone May 19, 2021
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexsafe alexsafe merged commit a92be23 into master May 19, 2021
@alexsafe alexsafe deleted the settings-new branch May 19, 2021 16:14
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Clear cache, cookies, history automatically/manually with on exit option
4 participants