-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit retry-loop when user tries linking their wallet with a different Uphold account. #9669
Merged
szilardszaloki
merged 1 commit into
master
from
sszaloki-17271-show-notification-on-two-different-uphold-accounts
Aug 10, 2021
Merged
Exit retry-loop when user tries linking their wallet with a different Uphold account. #9669
szilardszaloki
merged 1 commit into
master
from
sszaloki-17271-show-notification-on-two-different-uphold-accounts
Aug 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenparsing
reviewed
Aug 5, 2021
components/brave_rewards/resources/extension/brave_rewards/_locales/en_US/messages.json
Show resolved
Hide resolved
components/brave_rewards/resources/extension/brave_rewards/_locales/en_US/messages.json
Outdated
Show resolved
Hide resolved
548f7b4
to
e0e8ad3
Compare
zenparsing
approved these changes
Aug 10, 2021
emerick
approved these changes
Aug 10, 2021
vendor/bat-native-ledger/src/bat/ledger/internal/uphold/uphold_wallet.cc
Outdated
Show resolved
Hide resolved
e0e8ad3
to
6cf734d
Compare
…ent Uphold account. Adding the "mismatched provider accounts" notification. Kicking back the wallet to NOT_CONNECTED. Adjusting unit tests.
6cf734d
to
130ba33
Compare
brave-builds
pushed a commit
that referenced
this pull request
Aug 10, 2021
7 tasks
Nice work on this! This is a great fix 😄 |
Verified with
Scenario 1: Clean profile
TBD:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#17271, resolves brave/brave-browser#17265.
mismatched provider accounts
notificationNOT_CONNECTED
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: