Adds provider text to siteBanner #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
previously requested changes
Dec 3, 2018
| @@ -17,6 +17,7 @@ namespace brave_rewards { | |||
| background(""), | |||
| logo(""), | |||
| amounts(std::vector<int>()), | |||
| provider(""), | |||
There was a problem hiding this comment.
*nit: We should use std::string() instead of "" for empty strings.
|
I'm also not getting provider text (if I comment out the tsx line to allow building): |
|
Text missing expected? |
|
@jasonrsadler forgot to add the locale to "donate", fixed |
jasonrsadler
approved these changes
Dec 3, 2018
NejcZdovc
pushed a commit
that referenced
this pull request
Dec 4, 2018
Adds provider text to siteBanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#2238
Please use this native ledger PR to test: brave-intl/bat-native-ledger#186
brave-ui update: brave/brave-ui#294
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Defined in issue, see: brave/brave-browser#2238
Reviewer Checklist: