Handle microsoft-edge: protocol on Windows #9778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
changed the title
simonhong
changed the title
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
from
463868d
to
1d82c6f
Compare
|
|
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
2 times, most recently
from
735cf40
to
1441f35
Compare
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
2 times, most recently
from
17d42e5
to
15e9692
Compare
goodov
reviewed
Aug 23, 2021
chromium_src/chrome/browser/ui/startup/startup_browser_creator.cc
Outdated
Show resolved
Hide resolved
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
from
15e9692
to
4bd077b
Compare
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
from
4bd077b
to
1f6d2a5
Compare
When Brave is set as a default app for microsoft-edge protocol, Windows will pass "microsoft-edge:XXX" as command line arguments. This edge protocol includes url information. To make browser load passed url included in edge protocol, browser should parse url info from ms-edge protocol args and appends url alone to command line again. Then, that url will be loaded during the startup process.
With this, brave will be visible in the microsoft-edge target app list in control panel.
BraveMainDelegate::BasicStartupComplete() is not called again when browser is already running. So, it's not good place to handle command line args. Instead, StartupBrowserCreatorImpl::Launch() is proper place to get url from command line.
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
from
1f6d2a5
to
0068900
Compare
goodov
approved these changes
Aug 24, 2021
chromium_src/chrome/browser/ui/startup/startup_browser_creator.cc
Outdated
Show resolved
Hide resolved
bsclifton
reviewed
Aug 24, 2021
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
from
0068900
to
05e5767
Compare
simonhong
commented
Aug 24, 2021
chromium_src/chrome/browser/ui/startup/startup_browser_creator.cc
Outdated
Show resolved
Hide resolved
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
from
05e5767
to
3ebce84
Compare
bsclifton
reviewed
Aug 24, 2021
simonhong
force-pushed
the
handle_ms_edge_protocol
branch
from
3ebce84
to
fef40c5
Compare
simonhong
added
CI/skip-android
bsclifton
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Brave is set as a default app for microsoft-edge protocol,
Windows will pass "microsoft-edge:XXX" as command line arguments.
This edge protocol includes url information.
To make browser load passed url included in edge protocol, browser
should parse ms-edge protocol args fetch url from it.
Then, new browser or existing browser window will load that url.
Resolves brave/brave-browser#13875
Security review: https://github.com/brave/security/issues/552
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
npm run test brave_unit_tests -- --filter=*MSEdgeProtocolTest*Use the Windows
Defaultsprogram to set themicrosoft-edgehandler manuallyTest 1 - from chrome uninstall process
Test 2 - search from windows task bar
Test 3 - uninstall