CRLsets reintroduced #997
Merged
CRLsets reintroduced #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by: https://github.com/brave/devops/issues/451 |
auditors: @bridiver
jumde
force-pushed
the
crlset_reintroduced
branch
3 times, most recently
from
5bc353a to
3659b8c
Compare
1. Proxy requests for CRLSets through crlsets[n].brave.com 2. Proxy requests for update.googleapis.com through componentupdater.brave.com 3. Proxy requests for clients2.googleusercontent.com through crxdownload.brave.com
jumde
force-pushed
the
crlset_reintroduced
branch
from
3659b8c to
987bf7b
Compare
pilgrim-brave
approved these changes
Dec 4, 2018
|
Verified on Ubuntu, works as expected. |
|
master - 1a388e4 |
Merged
18 tasks
|
Doh sorry in advance but have to revert this again. Let's reland once we have the fix in brave/go-update. |
This was referenced Dec 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#518
fix brave/brave-browser#2160
CRLSets was reverted, this PR contains these changes:
update.googleapis.comthroughcomponentupdater.brave.comclients2.googleusercontent.comthroughcrxdownload.brave.comSubmitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
<data-dir>/CertificateRevocation/<dir>and check if crl-sets are populated.fix/network-audit-crlsetand runnpm run network-auditto verify the audit passes.Reviewer Checklist: