Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

BAT Points change #1822

Closed
anthonypkeane opened this issue Oct 29, 2019 · 1 comment
Closed

BAT Points change #1822

anthonypkeane opened this issue Oct 29, 2019 · 1 comment
Assignees
@kylehickinson
Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.13

Comments

@anthonypkeane
Copy link

anthonypkeane commented Oct 29, 2019 •
edited
Loading

Description

The updated requirement for BAT Points is:

  • Anywhere we have "BAT", change it to "BAP"
    (This requires change the previous logic where in some cases we changed BAT to BAT Points.)

  • Anywhere we have "Tokens", change for "Points"

NOTE: This is for JAPAN region only

Desktop Issue: brave/brave-browser#6654
@anthonypkeane anthonypkeane added this to the 1.13 milestone Oct 29, 2019
@kylehickinson kylehickinson self-assigned this Oct 29, 2019
kylehickinson added a commit that referenced this issue Oct 29, 2019
@kylehickinson
Fix #1822: Switch "BAT Points" to "BAP" and "tokens" to "points" in JP
704ae9a
kylehickinson added a commit that referenced this issue Oct 29, 2019
@kylehickinson
Fix #1822: Switch "BAT Points" to "BAP" and "tokens" to "points" in JP
12db80f
@kylehickinson kylehickinson mentioned this issue Oct 29, 2019
Merged
7 tasks
@srirambv srirambv mentioned this issue Oct 30, 2019
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.2 running 1.13(19.10.30.21)

  • Verified as per spec BAT is replaced with BAP
  • Verified as per spec Tokens are replaced with Points
    xr1
    xr2
    xr3
    xr4
    xr5
    xr6
    xr7
    xr8
    xr9
    xr10
    xr11
    xr12
    xr13
    xr14
    xr15
    xr71

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.10.30.21)

  • Verified as per spec BAT is replaced with BAP
  • Verified as per spec Tokens are replaced with Points
    iphone3
    iphone4
    iphone5
    iphone6
    iphone7
    iphone8
    iphone9
    iphone10
    iphone11
    iphone12
    iphone13
    iphone14
    iphone15

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.30.21)

  • Verified as per spec BAT is replaced with BAP
  • Verified as per spec Tokens are replaced with Points
    ipad1
    ipad2
    ipad3
    ipad4
    ipad5
    ipad6
    ipad7
    ipad8
    ipad9
    ipad10
    ipad11

Verification passed on iPhone 6 with iOS 12.4 running 1.13(19.10.30.21)

  • Verified as per spec BAT is replaced with BAP
  • Verified as per spec Tokens are replaced with Points
    iphone1
    iphone2
    iphone3
    iphone4
    iphone5
    iphone6
    iphone7
    iphone8
    iphone9
    iphone10
    iphone11
    iphone12
    iphone13
    iphone14
    iphone15

Verification passed on iPad Pro with iOS 12.4 running 1.13(19.10.30.21)

  • Verified as per spec BAT is replaced with BAP
  • Verified as per spec Tokens are replaced with Points
    ac budget
    ac list
    ads
    empty tips
    Image from iOS (2)
    one time tip
    panel
    recurring tip
    tips panel
    tips processed
    tips summary
    Wallet summary after contrib
    wallet summary befrore contrib

Logged #1842 for missing points in onboarding.

@srirambv srirambv mentioned this issue Nov 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
3 participants
@kylehickinson @anthonypkeane @srirambv