Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Implement cosmetic filtering #2683

Closed
pes10k opened this issue Jul 1, 2020 · 5 comments · Fixed by #5060
Closed

Implement cosmetic filtering #2683

pes10k opened this issue Jul 1, 2020 · 5 comments · Fixed by #5060

Comments

@pes10k
Copy link
Collaborator

pes10k commented Jul 1, 2020

Since cosmetic filtering doesn't have the same timing issues as request blocking, it wouldn't need to go through the iOS content blocking / declarative system.

Most (all?) of this information and functionality should already be available in the rust DAT and adblock-rust. Also, likely a lot of the brave-core brave_extension content script code could be reused

@kylehickinson
Copy link
Collaborator

Blocked by #3683

@kylehickinson kylehickinson added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label May 12, 2021
@anthonypkeane
Copy link

For a spec, please search for "Cosmetic Filters and Scriptlet Injections" in GDrive

iccub pushed a commit that referenced this issue Mar 23, 2022
@iccub iccub added this to the 1.37 milestone Mar 23, 2022
@iccub iccub added enhancement and removed blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue labels Mar 23, 2022
@Uni-verse
Copy link
Contributor

Verified using version 1.37 (22.3.29.15)

Devices:
iPhone 12 Pro | iOS 15.4
iPad (7th Gen) | iOS 15.2.1
iPhone X | iOS 14.4.2

  • Verified that ads on youtube are blocked correctly.
  • Verified that the non-video ads that show up below a video are blocked correctly.
iPhone ads blocked iPhone in-content ad iPad ads blocked iPad in-content ad
IMG_2568 IMG_2567 IMG_0232 IMG_0233

@iccub
Copy link
Contributor

iccub commented Apr 5, 2022

Let's reopen to verify together with #5208

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 5, 2022

Verified using RC #2 version 1.37 (22.4.5.19)

Devices:

  • iPhone 12 running iOS 15.4
  • iPhone X running iOS 14.4.2
  • iPad running iOS 15.2.1

PASS - Verified that ads on youtube are blocked correctly.
PASS - Verified that the non-video ads that show up below a video are blocked correctly.

Shields Off Shields On
IMG_2580 IMG_2581 3
Shields Off (iPad) Shields On (iPad)
IMG_0243 IMG_0244

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.